]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: rme9652: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:07:04 +0000 (12:07 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:22 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-83-tiwai@suse.de
sound/pci/rme9652/rme9652.c

index 34d9c7995ddd02f40764bbacc8b7a75657b48161..7dc8e3777c37d2a713b7e111ec669e332d0d94d3 100644 (file)
@@ -2364,7 +2364,7 @@ static int snd_rme9652_create_pcm(struct snd_card *card,
 
        rme9652->pcm = pcm;
        pcm->private_data = rme9652;
-       strcpy(pcm->name, rme9652->card_name);
+       strscpy(pcm->name, rme9652->card_name);
 
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_rme9652_playback_ops);
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &snd_rme9652_capture_ops);
@@ -2447,7 +2447,7 @@ static int snd_rme9652_create(struct snd_card *card,
 
        switch (rev) {
        case 8: /* original eprom */
-               strcpy(card->driver, "RME9636");
+               strscpy(card->driver, "RME9636");
                if (rme9652->hw_rev == 15) {
                        rme9652->card_name = "RME Digi9636 (Rev 1.5)";
                } else {
@@ -2456,17 +2456,17 @@ static int snd_rme9652_create(struct snd_card *card,
                rme9652->ss_channels = RME9636_NCHANNELS;
                break;
        case 9: /* W36_G EPROM */
-               strcpy(card->driver, "RME9636");
+               strscpy(card->driver, "RME9636");
                rme9652->card_name = "RME Digi9636 (Rev G)";
                rme9652->ss_channels = RME9636_NCHANNELS;
                break;
        case 4: /* W52_G EPROM */
-               strcpy(card->driver, "RME9652");
+               strscpy(card->driver, "RME9652");
                rme9652->card_name = "RME Digi9652 (Rev G)";
                rme9652->ss_channels = RME9652_NCHANNELS;
                break;
        case 3: /* original eprom */
-               strcpy(card->driver, "RME9652");
+               strscpy(card->driver, "RME9652");
                if (rme9652->hw_rev == 15) {
                        rme9652->card_name = "RME Digi9652 (Rev 1.5)";
                } else {
@@ -2539,7 +2539,7 @@ static int snd_rme9652_probe(struct pci_dev *pci,
        if (err)
                goto error;
 
-       strcpy(card->shortname, rme9652->card_name);
+       strscpy(card->shortname, rme9652->card_name);
 
        sprintf(card->longname, "%s at 0x%lx, irq %d",
                card->shortname, rme9652->port, rme9652->irq);