CLEANUP: ebmbtree: Replace always-taken elseif by else

`diff` is guaranteed to be less than 0, because the `if` handles the `>= 0`
case.

Found using GitHub's CodeQL scan in HAProxy's codebase.

diff --git a/include/import/ebmbtree.h b/include/import/ebmbtree.h
index f99c16ba9a4b1d4ea58fa751d18f25ac083a7d82..1a454262475cbc6d0b7be8f21195da92c0301677 100644 (file)
--- a/include/import/ebmbtree.h
+++ b/include/import/ebmbtree.h
@@ -358,7 +358,7 @@ __ebmb_insert(struct eb_root *root, struct ebmb_node *new, unsigned int len)
                new->node.leaf_p = new_rght;
                *up_ptr = new_left;
        }
-       else if (diff < 0) {
+       else {
                new->node.branches.b[EB_LEFT] = new_leaf;
                new->node.branches.b[EB_RGHT] = troot;
                new->node.leaf_p = new_left;