]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: scsi_debug: Drop NULL scsi_cmnd check in sdebug_q_cmd_complete()
authorJohn Garry <john.g.garry@oracle.com>
Thu, 13 Nov 2025 13:36:42 +0000 (13:36 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 17 Dec 2025 02:48:22 +0000 (21:48 -0500)
The scp pointer cannot be NULL, as it is evaluated from container_of()
and pointer offsets (so remove the check in sdebug_q_cmd_complete()).

Signed-off-by: John Garry <john.g.garry@oracle.com>
Link: https://patch.msgid.link/20251113133645.2898748-4-john.g.garry@oracle.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_debug.c

index cbe15a76a98bd1024c313f177c52fc743d6d7be4..9f17e9c49cb5d33f16f3a621fec9f2ca87f8d915 100644 (file)
@@ -6396,11 +6396,6 @@ static void sdebug_q_cmd_complete(struct sdebug_defer *sd_dp)
                        atomic_inc(&sdebug_miss_cpus);
        }
 
-       if (!scp) {
-               pr_err("scmd=NULL\n");
-               return;
-       }
-
        spin_lock_irqsave(&sdsc->lock, flags);
        aborted = sd_dp->aborted;
        if (unlikely(aborted))