]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
misc: tps6594-pfsm: Add NULL pointer check in tps6594_pfsm_probe()
authorChenyuan Yang <chenyuan0y@gmail.com>
Tue, 11 Mar 2025 01:05:11 +0000 (20:05 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 6 Jul 2025 09:00:07 +0000 (11:00 +0200)
[ Upstream commit a99b598d836c9c6411110c70a2da134c78d96e67 ]

The returned value, pfsm->miscdev.name, from devm_kasprintf()
could be NULL.
A pointer check is added to prevent potential NULL pointer dereference.
This is similar to the fix in commit 3027e7b15b02
("ice: Fix some null pointer dereference issues in ice_ptp.c").

This issue is found by our static analysis tool.

Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Link: https://lore.kernel.org/r/20250311010511.1028269-1-chenyuan0y@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/misc/tps6594-pfsm.c

index 88dcac8148922c7f5dc8fcf7147f7dc218c26728..71fbe31542e562152ac292c348d1a03d9cbc3c04 100644 (file)
@@ -260,6 +260,9 @@ static int tps6594_pfsm_probe(struct platform_device *pdev)
        pfsm->miscdev.minor = MISC_DYNAMIC_MINOR;
        pfsm->miscdev.name = devm_kasprintf(dev, GFP_KERNEL, "pfsm-%ld-0x%02x",
                                            tps->chip_id, tps->reg);
+       if (!pfsm->miscdev.name)
+               return -ENOMEM;
+
        pfsm->miscdev.fops = &tps6594_pfsm_fops;
        pfsm->miscdev.parent = dev->parent;