]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: gpib: Correct CamelCase for VALID enums
authorMichael Rubin <matchstick@neverthere.org>
Wed, 19 Mar 2025 21:18:27 +0000 (21:18 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Mar 2025 13:57:05 +0000 (06:57 -0700)
Adhere to Linux kernel coding style.

Reported by checkpatch

CHECK: Avoid CamelCase

Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Acked-By: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250319211827.9854-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 files changed:
drivers/staging/gpib/agilent_82357a/agilent_82357a.c
drivers/staging/gpib/cb7210/cb7210.c
drivers/staging/gpib/common/iblib.c
drivers/staging/gpib/eastwood/fluke_gpib.c
drivers/staging/gpib/fmh_gpib/fmh_gpib.c
drivers/staging/gpib/gpio/gpib_bitbang.c
drivers/staging/gpib/ines/ines_gpib.c
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
drivers/staging/gpib/ni_usb/ni_usb_gpib.c
drivers/staging/gpib/tms9914/tms9914.c
drivers/staging/gpib/tnt4882/tnt4882_gpib.c
drivers/staging/gpib/uapi/gpib_user.h

index 17f41817587b91e521c0ab1b1b96927908de4085..4dda899ff1b2ee08c986795b3f0f909c6a4a89da 100644 (file)
@@ -1017,7 +1017,7 @@ static int agilent_82357a_line_status(const gpib_board_t *board)
        struct usb_device *usb_dev;
        struct agilent_82357a_register_pairlet bus_status;
        int retval;
-       int status = ValidALL;
+       int status = VALID_ALL;
 
        if (!a_priv->bus_interface)
                return -ENODEV;
index ba02dce62dd97cebda5725903626bb80b84114ce..808e0a71dfd6a579670903b669d1c1fccd49c175 100644 (file)
@@ -379,7 +379,7 @@ static int cb7210_accel_write(gpib_board_t *board, uint8_t *buffer, size_t lengt
 
 static int cb7210_line_status(const gpib_board_t *board)
 {
-       int status = ValidALL;
+       int status = VALID_ALL;
        int bsr_bits;
        struct cb7210_priv *cb_priv;
 
index 1caa57b41596469009788bd1e8c30918783199cb..92e792e123017d59d7eab347b5dfbd575b7df0c5 100644 (file)
@@ -76,7 +76,7 @@ static int check_for_command_acceptors(gpib_board_t *board)
        if (lines < 0)
                return lines;
 
-       if ((lines & ValidNRFD) && (lines & ValidNDAC)) {
+       if ((lines & VALID_NRFD) && (lines & VALID_NDAC))       {
                if ((lines & BUS_NRFD) == 0 && (lines & BUS_NDAC) == 0)
                        return -ENOTCONN;
        }
@@ -520,7 +520,7 @@ int general_ibstatus(gpib_board_t *board, const gpib_status_queue_t *device,
                status &= ~TIMO;
                /* get real SRQI status if we can */
                if (iblines(board, &line_status) == 0) {
-                       if ((line_status & ValidSRQ)) {
+                       if ((line_status & VALID_SRQ)) {
                                if ((line_status & BUS_SRQ))
                                        status |= SRQI;
                                else
index 4e04acfdb48d45cb01d0d1764877d7216ceb79d9..bcddf3125b8cb1b40be3fe7bce7761982727ad27 100644 (file)
@@ -195,7 +195,7 @@ static void fluke_return_to_local(gpib_board_t *board)
 
 static int fluke_line_status(const gpib_board_t *board)
 {
-       int status = ValidALL;
+       int status = VALID_ALL;
        int bsr_bits;
        struct fluke_priv *e_priv;
 
index 8fbfa7e285af44c87808e4a35419844b78fa4fee..3e8ad8aa332f5555064781a1b0f1ea3ff221c159 100644 (file)
@@ -229,7 +229,7 @@ static void fmh_gpib_return_to_local(gpib_board_t *board)
 
 static int fmh_gpib_line_status(const gpib_board_t *board)
 {
-       int status = ValidALL;
+       int status = VALID_ALL;
        int bsr_bits;
        struct fmh_priv *e_priv;
        struct nec7210_priv *nec_priv;
index 004bf0e9bc888cfde2e83e78bd9e74378602c6e4..28c5fa9b81abef84902d2f12a1d42893871eaa25 100644 (file)
@@ -1031,7 +1031,7 @@ static void bb_return_to_local(gpib_board_t *board)
 
 static int bb_line_status(const gpib_board_t *board)
 {
-       int line_status = ValidALL;
+       int line_status = VALID_ALL;
 
        if (gpiod_get_value(REN) == 0)
                line_status |= BUS_REN;
index c5c34845fc382363ea4fa42d614115effba2ddc1..d31eab1a05e44efd8f1d0827d06480dc7955e0ee 100644 (file)
@@ -27,7 +27,7 @@ MODULE_DESCRIPTION("GPIB driver for Ines iGPIB 72010");
 
 int ines_line_status(const gpib_board_t *board)
 {
-       int status = ValidALL;
+       int status = VALID_ALL;
        int bcm_bits;
        struct ines_priv *ines_priv;
 
index 2775dc83305ecb67a69795a9a72ffb211855eead..011096ece7d633b0ae09b617e63da54dc07230fe 100644 (file)
@@ -658,7 +658,7 @@ static void usb_gpib_interface_clear(gpib_board_t *board, int assert)
 static int usb_gpib_line_status(const gpib_board_t *board)
 {
        int buffer;
-       int line_status = ValidALL;   /* all lines will be read */
+       int line_status = VALID_ALL;   /* all lines will be read */
        struct list_head *p, *q;
        WQT *item;
        unsigned long flags;
index a788af70fa64890e7c87938913bc00e5e1e1ae1c..2de5aaea2615079c1f7feacca2be5acec5644ea2 100644 (file)
@@ -1508,7 +1508,7 @@ static int ni_usb_line_status(const gpib_board_t *board)
        int bytes_written = 0, bytes_read = 0;
        int i = 0;
        unsigned int bsr_bits;
-       int line_status = ValidALL;
+       int line_status = VALID_ALL;
        // NI windows driver reads 0xd(HSSEL), 0xc (ARD0), 0x1f (BSR)
 
        if (!ni_priv->bus_interface)
index 17adeccf448bb64cbb0dc3d75ed7ab1050c48469..c563fcab44fc0cc7cfba92d46ed72bba5510c65c 100644 (file)
@@ -391,7 +391,7 @@ static unsigned int update_status_nolock(gpib_board_t *board, struct tms9914_pri
 int tms9914_line_status(const gpib_board_t *board, struct tms9914_priv *priv)
 {
        int bsr_bits;
-       int status = ValidALL;
+       int status = VALID_ALL;
 
        bsr_bits = read_byte(priv, BSR);
 
index 76fd9422809c1f41d2137c489ef8e94824cadc2f..e62f3424ca20728123c8161bc28c4f60138cbca4 100644 (file)
@@ -150,7 +150,7 @@ MODULE_DESCRIPTION("GPIB driver for National Instruments boards using tnt4882 or
 
 static int tnt4882_line_status(const gpib_board_t *board)
 {
-       int status = ValidALL;
+       int status = VALID_ALL;
        int bcsr_bits;
        struct tnt4882_priv *tnt_priv;
 
index 2d742540630a2d784736f8e11fb4c4ed9df97e68..5ff4588686fde328cb78448694988eaa792b3757 100644 (file)
@@ -106,15 +106,15 @@ enum eos_flags {
 
 /* GPIB Bus Control Lines bit vector */
 enum bus_control_line {
-       ValidDAV = 0x01,
-       ValidNDAC = 0x02,
-       ValidNRFD = 0x04,
-       ValidIFC = 0x08,
-       ValidREN = 0x10,
-       ValidSRQ = 0x20,
-       ValidATN = 0x40,
-       ValidEOI = 0x80,
-       ValidALL = 0xff,
+       VALID_DAV = 0x01,
+       VALID_NDAC = 0x02,
+       VALID_NRFD = 0x04,
+       VALID_IFC = 0x08,
+       VALID_REN = 0x10,
+       VALID_SRQ = 0x20,
+       VALID_ATN = 0x40,
+       VALID_EOI = 0x80,
+       VALID_ALL = 0xff,
        BUS_DAV = 0x0100,               /* DAV  line status bit */
        BUS_NDAC = 0x0200,              /* NDAC line status bit */
        BUS_NRFD = 0x0400,              /* NRFD line status bit */