]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/panel/novatek-nt36672a: Use refcounted allocation in place of devm_kzalloc()
authorAnusha Srivatsa <asrivats@redhat.com>
Fri, 11 Jul 2025 04:31:16 +0000 (23:31 -0500)
committerMaxime Ripard <mripard@kernel.org>
Wed, 16 Jul 2025 14:58:10 +0000 (16:58 +0200)
Move to using the new API devm_drm_panel_alloc() to allocate the
panel. In the call to the new API, avoid using explicit type and use
__typeof() for more type safety.

Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
Link: https://lore.kernel.org/r/20250710-b4-driver-convert-last-part-july-v1-5-de73ba81b2f5@redhat.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/panel/panel-novatek-nt36672a.c

index c2abd20e0734bd1e94fa3692e41d442170ab24c3..29e1f6aea48060384f4639999174b67097a6c8a7 100644 (file)
@@ -608,8 +608,6 @@ static int nt36672a_panel_add(struct nt36672a_panel *pinfo)
                return dev_err_probe(dev, PTR_ERR(pinfo->reset_gpio),
                                     "failed to get reset gpio from DT\n");
 
-       drm_panel_init(&pinfo->base, dev, &panel_funcs, DRM_MODE_CONNECTOR_DSI);
-
        ret = drm_panel_of_backlight(&pinfo->base);
        if (ret)
                return dev_err_probe(dev, ret, "Failed to get backlight\n");
@@ -625,9 +623,11 @@ static int nt36672a_panel_probe(struct mipi_dsi_device *dsi)
        const struct nt36672a_panel_desc *desc;
        int err;
 
-       pinfo = devm_kzalloc(&dsi->dev, sizeof(*pinfo), GFP_KERNEL);
-       if (!pinfo)
-               return -ENOMEM;
+       pinfo = devm_drm_panel_alloc(&dsi->dev, __typeof(*pinfo), base,
+                                    &panel_funcs, DRM_MODE_CONNECTOR_DSI);
+
+       if (IS_ERR(pinfo))
+               return PTR_ERR(pinfo);
 
        desc = of_device_get_match_data(&dsi->dev);
        dsi->mode_flags = desc->mode_flags;