]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
varlink: address some trivial points Claude found
authorLennart Poettering <lennart@amutable.com>
Sun, 26 Apr 2026 18:50:09 +0000 (20:50 +0200)
committerLennart Poettering <lennart@amutable.com>
Sun, 26 Apr 2026 18:50:09 +0000 (20:50 +0200)
Just addressing Claude's last review from #41815

src/libsystemd/sd-varlink/varlink-util.c
src/test/test-varlink.c

index 475bec40d844f45a3fb48f7a43406dd28e1fc962..7b8797c92c85b23ec7d71e1d0985c2d47b443b86 100644 (file)
@@ -335,7 +335,7 @@ ssize_t varlink_execute_directory(
 
                 r = sd_varlink_set_relative_timeout(link, timeout_usec);
                 if (r < 0)
-                        return r;
+                        return log_debug_errno(r, "Failed to set relative timeout: %m");
 
                 if (more)
                         r = sd_varlink_observe(link, method, parameters);
index 8cdbfafaa2ae9b2ad92cba05e84d14e12f71fd63..72edc033dd068810e7830dba1557125032839a09 100644 (file)
@@ -1009,7 +1009,7 @@ TEST(execute_directory) {
                                      /* timeout_usec= */ USEC_INFINITY,
                                      execute_dir_reply,
                                      &reply_count), (ssize_t) ELEMENTSOF(names));
-        ASSERT_EQ(reply_count, (unsigned) ELEMENTSOF(names));
+        ASSERT_EQ(reply_count, ELEMENTSOF(names));
 
         FOREACH_ELEMENT(eds, servers) {
                 ASSERT_OK(-pthread_join(eds->thread, NULL));