]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq: s5pv210: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 9 Jan 2026 16:57:55 +0000 (17:57 +0100)
committerRob Herring (Arm) <robh@kernel.org>
Wed, 4 Feb 2026 02:58:13 +0000 (20:58 -0600)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.  Note that there is another part of code using "np"
variable, so scoped loop should not shadow it.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260109-of-for-each-compatible-scoped-v3-11-c22fa2c0749a@oss.qualcomm.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/cpufreq/s5pv210-cpufreq.c

index ba8a1c96427a105937919b2efd468c59ef469564..e64e84e1ee79ead9e2a8d6e35eed67e71e2e7031 100644 (file)
@@ -629,19 +629,17 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev)
                goto err_clock;
        }
 
-       for_each_compatible_node(np, NULL, "samsung,s5pv210-dmc") {
-               id = of_alias_get_id(np, "dmc");
+       for_each_compatible_node_scoped(dmc, NULL, "samsung,s5pv210-dmc") {
+               id = of_alias_get_id(dmc, "dmc");
                if (id < 0 || id >= ARRAY_SIZE(dmc_base)) {
-                       dev_err(dev, "failed to get alias of dmc node '%pOFn'\n", np);
-                       of_node_put(np);
+                       dev_err(dev, "failed to get alias of dmc node '%pOFn'\n", dmc);
                        result = id;
                        goto err_clk_base;
                }
 
-               dmc_base[id] = of_iomap(np, 0);
+               dmc_base[id] = of_iomap(dmc, 0);
                if (!dmc_base[id]) {
                        dev_err(dev, "failed to map dmc%d registers\n", id);
-                       of_node_put(np);
                        result = -EFAULT;
                        goto err_dmc;
                }