]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netdevsim: remove redundant branch
authorDennis Chen <dechen@redhat.com>
Wed, 16 Jul 2025 16:57:50 +0000 (12:57 -0400)
committerJakub Kicinski <kuba@kernel.org>
Fri, 18 Jul 2025 01:09:27 +0000 (18:09 -0700)
bool notify is referenced nowhere else in the function except to check
whether or not to call rtnl_offload_xstats_notify(). Remove it and move
the call to the previous branch.

Signed-off-by: Dennis Chen <dechen@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Link: https://patch.msgid.link/20250716165750.561175-1-dechen@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/netdevsim/hwstats.c

index 66b3215db3acdec5d737c03e163fc66e471bcca5..1abe48e35ca3a75bfb20e4ce395dfa0922d86082 100644 (file)
@@ -220,7 +220,6 @@ nsim_dev_hwstats_enable_ifindex(struct nsim_dev_hwstats *hwstats,
        struct nsim_dev_hwstats_netdev *hwsdev;
        struct nsim_dev *nsim_dev;
        struct net_device *netdev;
-       bool notify = false;
        struct net *net;
        int err = 0;
 
@@ -251,11 +250,9 @@ nsim_dev_hwstats_enable_ifindex(struct nsim_dev_hwstats *hwstats,
 
        if (netdev_offload_xstats_enabled(netdev, type)) {
                nsim_dev_hwsdev_enable(hwsdev, NULL);
-               notify = true;
+               rtnl_offload_xstats_notify(netdev);
        }
 
-       if (notify)
-               rtnl_offload_xstats_notify(netdev);
        rtnl_unlock();
        return err;