]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDomainNetDefParseXML: Automatically free GHashTable
authorPeter Krempa <pkrempa@redhat.com>
Tue, 30 Nov 2021 10:33:10 +0000 (11:33 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 1 Dec 2021 12:53:11 +0000 (13:53 +0100)
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/conf/domain_conf.c

index 5cd1bede02bcae41d7410d46139a373942b7d07b..14aeda45731b9d4254930e6a79f1b96d16e873a1 100644 (file)
@@ -10221,7 +10221,7 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
     xmlNodePtr vlan_node = NULL;
     xmlNodePtr bandwidth_node = NULL;
     xmlNodePtr tmpNode;
-    GHashTable *filterparams = NULL;
+    g_autoptr(GHashTable) filterparams = NULL;
     virDomainActualNetDef *actual = NULL;
     VIR_XPATH_NODE_AUTORESTORE(ctxt)
     virDomainChrSourceReconnectDef reconnect = {0};
@@ -10408,7 +10408,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
 
     if ((filterref_node = virXPathNode("./filterref", ctxt))) {
         filter = virXMLPropString(filterref_node, "filter");
-        virHashFree(filterparams);
         filterparams = virNWFilterParseParamAttributes(filterref_node);
     }
 
@@ -10937,7 +10936,6 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
 
  cleanup:
     virDomainActualNetDefFree(actual);
-    virHashFree(filterparams);
     return def;
 
  error: