]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: imx-jpeg: Simplify descriptor initialization with memset
authorMing Qian <ming.qian@oss.nxp.com>
Tue, 3 Feb 2026 08:23:38 +0000 (16:23 +0800)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 23 Mar 2026 10:18:33 +0000 (11:18 +0100)
Use memset() to zero-initialize desc and cfg_desc structures instead of
assigning individual fields to zero. This is cleaner and ensures all
descriptor fields are properly initialized.

No functional change.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Ming Qian <ming.qian@oss.nxp.com>
Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c

index b442dcba02e78ca8eff9d5f3a7120eddb0a22321..7dc975792dedec610c4659e071ac92be59eb9310 100644 (file)
@@ -1338,6 +1338,8 @@ static void mxc_jpeg_config_enc_desc(struct vb2_buffer *out_buf,
 
        q_data = mxc_jpeg_get_q_data(ctx, src_buf->vb2_queue->type);
 
+       memset(desc, 0, sizeof(struct mxc_jpeg_desc));
+       memset(cfg_desc, 0, sizeof(struct mxc_jpeg_desc));
        jpeg->slot_data.cfg_stream_size =
                        mxc_jpeg_setup_cfg_stream(cfg_stream_vaddr,
                                                  q_data->fmt->fourcc,
@@ -1348,11 +1350,6 @@ static void mxc_jpeg_config_enc_desc(struct vb2_buffer *out_buf,
        cfg_desc->next_descpt_ptr = desc_handle | MXC_NXT_DESCPT_EN;
 
        cfg_desc->buf_base0 = jpeg->slot_data.cfg_stream_handle;
-       cfg_desc->buf_base1 = 0;
-       cfg_desc->line_pitch = 0;
-       cfg_desc->stm_bufbase = 0; /* no output expected */
-       cfg_desc->stm_bufsize = 0x0;
-       cfg_desc->imgsize = 0;
        cfg_desc->stm_ctrl = STM_CTRL_CONFIG_MOD(1);
        cfg_desc->stm_ctrl |= STM_CTRL_BITBUF_PTR_CLR(1);