]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: usb-audio: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:07:21 +0000 (12:07 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:53:35 +0000 (09:53 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-100-tiwai@suse.de
sound/usb/card.c
sound/usb/midi.c
sound/usb/mixer.c
sound/usb/stream.c

index 9fb8726a6c935fabc28bb53297c9b982adf87d7e..630ce40ed2c95d0e55faa50ca273546fa21320c2 100644 (file)
@@ -756,7 +756,7 @@ static int snd_usb_audio_create(struct usb_interface *intf,
 
        card->private_free = snd_usb_audio_free;
 
-       strcpy(card->driver, "USB-Audio");
+       strscpy(card->driver, "USB-Audio");
        sprintf(component, "USB%04x:%04x",
                USB_ID_VENDOR(chip->usb_id), USB_ID_PRODUCT(chip->usb_id));
        snd_component_add(card, component);
index 866e613fee4f17fb92b6cc71fc95aed4dfda300b..acb3bf92857c101ae672f601d0bc2ccc265a949a 100644 (file)
@@ -2407,7 +2407,7 @@ static int snd_usbmidi_create_rawmidi(struct snd_usb_midi *umidi,
                              out_ports, in_ports, &rmidi);
        if (err < 0)
                return err;
-       strcpy(rmidi->name, umidi->card->shortname);
+       strscpy(rmidi->name, umidi->card->shortname);
        rmidi->info_flags = SNDRV_RAWMIDI_INFO_OUTPUT |
                            SNDRV_RAWMIDI_INFO_INPUT |
                            SNDRV_RAWMIDI_INFO_DUPLEX;
index 11be79af26db65c06d7e3c42a545dd2accab08a6..a7cd7d51e66b5b2ec1e222015cb3422d6c3e05b7 100644 (file)
@@ -3569,7 +3569,7 @@ int snd_usb_create_mixer(struct snd_usb_audio *chip, int ctrlif)
        struct usb_mixer_interface *mixer;
        int err;
 
-       strcpy(chip->card->mixername, "USB Mixer");
+       strscpy(chip->card->mixername, "USB Mixer");
 
        mixer = kzalloc(sizeof(*mixer), GFP_KERNEL);
        if (!mixer)
index aa91d63749f2ca34e906d1e1366ca9f095ac01ae..749498fbf9cb29522d00f40e24ced4baa43c0f87 100644 (file)
@@ -538,7 +538,7 @@ static int __snd_usb_add_audio_stream(struct snd_usb_audio *chip,
        if (chip->pcm_devs > 0)
                sprintf(pcm->name, "USB Audio #%d", chip->pcm_devs);
        else
-               strcpy(pcm->name, "USB Audio");
+               strscpy(pcm->name, "USB Audio");
 
        snd_usb_init_substream(as, stream, fp, pd);