mm/damon/tests/sysfs-kunit: fix use after free on error path

Re-order these frees to avoid dereferencing "sysfs_target" after it has
been freed.

Link: https://lkml.kernel.org/r/aSBq5uSPIqsqH8zO@stanley.mountain
Fixes: ee131696794c ("mm/damon/tests/sysfs-kunit: handle alloc failures on damon_sysfs_test_add_targets()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/damon/tests/sysfs-kunit.h b/mm/damon/tests/sysfs-kunit.h
index ce7218469f20b462a5f3aeb4dbe8765c4eb6335c..0c665ed255a342892c7493c540eceb952ff761e1 100644 (file)
--- a/mm/damon/tests/sysfs-kunit.h
+++ b/mm/damon/tests/sysfs-kunit.h
@@ -76,8 +76,8 @@ static void damon_sysfs_test_add_targets(struct kunit *test)
        if (!ctx) {
                kfree(sysfs_targets->targets_arr);
                kfree(sysfs_targets);
-               kfree(sysfs_target);
                kfree(sysfs_target->regions);
+               kfree(sysfs_target);
                kunit_skip(test, "ctx alloc fail");
        }