]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: exynos4-is: fimc-is: Fully open-code compatible for grepping
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 13 Jun 2025 07:15:57 +0000 (09:15 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Tue, 17 Jun 2025 08:35:16 +0000 (10:35 +0200)
It is very useful to find driver implementing compatibles with `git grep
compatible`, so driver should not use defines for that string, even if
this means string will be effectively duplicated.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.h
drivers/media/platform/samsung/exynos4-is/fimc-is.c

index b243cbb1d0100387537cc899fd55743c63c37faa..b5b37b6f8fa810a97a5271e796436b0e8478b105 100644 (file)
@@ -131,7 +131,7 @@ static const struct dev_pm_ops fimc_is_i2c_pm_ops = {
 };
 
 static const struct of_device_id fimc_is_i2c_of_match[] = {
-       { .compatible = FIMC_IS_I2C_COMPATIBLE },
+       { .compatible = "samsung,exynos4212-i2c-isp" },
        { },
 };
 
index a23bd20be6c8da14c4f552b084f7ea3b71a51b26..69d597e5c297c570fa4e5f7bc53cd2b72ec29891 100644 (file)
@@ -6,7 +6,5 @@
  * Sylwester Nawrocki <s.nawrocki@samsung.com>
  */
 
-#define FIMC_IS_I2C_COMPATIBLE "samsung,exynos4212-i2c-isp"
-
 int fimc_is_register_i2c_driver(void);
 void fimc_is_unregister_i2c_driver(void);
index 2e8fe9e497350bc6136268cecbb433dc6d4b3030..ed7b7ca16f71ac67b3714fedbaa66b17949146f8 100644 (file)
@@ -207,7 +207,7 @@ static int fimc_is_register_subdevs(struct fimc_is *is)
        if (ret < 0)
                return ret;
 
-       for_each_compatible_node(i2c_bus, NULL, FIMC_IS_I2C_COMPATIBLE) {
+       for_each_compatible_node(i2c_bus, NULL, "samsung,exynos4212-i2c-isp") {
                for_each_available_child_of_node(i2c_bus, child) {
                        ret = fimc_is_parse_sensor_config(is, index, child);