* grub-core/disk/diskfilter.c (scan_devices): Iteratively

	rescan diskfilter devices until nothing new is found.

diff --git a/ChangeLog b/ChangeLog
index e71a848548c9166509f84c61166dcef0821258dd..d8d85ede4c621fc72d7b7f293ccc2ba5bd75ea59 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-06-16  Andrey Borzenkov <arvidjaar@gmail.com>
+
+       * grub-core/disk/diskfilter.c (scan_devices): Iteratively
+       rescan diskfilter devices until nothing new is found.
+
 2013-06-16  Vladimir Serbinenko  <phcoder@gmail.com>
 
        Fix casts when compiling coreboot-specific code for 64-bit EFI.

diff --git a/grub-core/disk/diskfilter.c b/grub-core/disk/diskfilter.c
index c8d267a6b589fb7e0f616fce9e627730c711c3d3..045517726238129a92515da4ecc41e633ad93dfe 100644 (file)
--- a/grub-core/disk/diskfilter.c
+++ b/grub-core/disk/diskfilter.c
@@ -188,6 +188,7 @@ scan_disk (const char *name, int accept_diskfilter)
   if (!accept_diskfilter && is_valid_diskfilter_name (name))
     return 0;
 
+  /* FIXME do we still need it? It is not called recursively anymore */
   if (scan_depth > 100)
     return 0;
 
@@ -219,6 +220,8 @@ scan_devices (const char *arname)
   grub_disk_pull_t pull;
   struct grub_diskfilter_vg *vg;
   struct grub_diskfilter_lv *lv = NULL;
+  int scan_depth;
+  int need_rescan;
 
   for (pull = 0; pull < GRUB_DISK_PULL_MAX; pull++)
     for (p = grub_disk_dev_list; p; p = p->next)
@@ -231,16 +234,26 @@ scan_devices (const char *arname)
            return;
        }
 
-  for (vg = array_list; vg; vg = vg->next)
+  scan_depth = 0;
+  need_rescan = 1;
+  while (need_rescan && scan_depth++ < 100)
     {
-      if (vg->lvs)
-       for (lv = vg->lvs; lv; lv = lv->next)
-         if (!lv->scanned && lv->fullname && lv->became_readable_at)
-           {
-             scan_disk (lv->fullname, 1);
-             lv->scanned = 1;
-           }
+      need_rescan = 0;
+      for (vg = array_list; vg; vg = vg->next)
+       {
+         if (vg->lvs)
+           for (lv = vg->lvs; lv; lv = lv->next)
+             if (!lv->scanned && lv->fullname && lv->became_readable_at)
+               {
+                 scan_disk (lv->fullname, 1);
+                 lv->scanned = 1;
+                 need_rescan = 1;
+               }
+       }
     }
+
+  if (need_rescan)
+     grub_error (GRUB_ERR_UNKNOWN_DEVICE, "DISKFILTER scan depth exceeded");
 }
 
 static int