]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: Fix wrong return errno in *sanitize_name()
authorKari Argillander <kari.argillander@gmail.com>
Fri, 19 Dec 2025 15:48:14 +0000 (17:48 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Sat, 31 Jan 2026 15:38:31 +0000 (07:38 -0800)
Currently if user of *sanitize_name() function gives nullptr for name
they get's ENOMEM. Logically it should be EINVAL.

Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
Link: https://lore.kernel.org/r/20251219-hwmon-fixes-v1-1-21b29097ea3b@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/hwmon.c

index 0b4bdcd33c7b8d5394865068dfbfdde947a4a304..7a784d685d77f27e8541fc7906bf5b6367ef6b00 100644 (file)
@@ -1260,6 +1260,9 @@ static char *__hwmon_sanitize_name(struct device *dev, const char *old_name)
  */
 char *hwmon_sanitize_name(const char *name)
 {
+       if (!name)
+               return ERR_PTR(-EINVAL);
+
        return __hwmon_sanitize_name(NULL, name);
 }
 EXPORT_SYMBOL_GPL(hwmon_sanitize_name);
@@ -1276,7 +1279,7 @@ EXPORT_SYMBOL_GPL(hwmon_sanitize_name);
  */
 char *devm_hwmon_sanitize_name(struct device *dev, const char *name)
 {
-       if (!dev)
+       if (!dev || !name)
                return ERR_PTR(-EINVAL);
 
        return __hwmon_sanitize_name(dev, name);