]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vbox: Don't check the output of virGetUserCacheDirectory()
authorFabiano Fidêncio <fidencio@redhat.com>
Thu, 19 Dec 2019 08:50:34 +0000 (09:50 +0100)
committerFabiano Fidêncio <fidencio@redhat.com>
Fri, 20 Dec 2019 08:38:43 +0000 (09:38 +0100)
virGetUserCacheDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/vbox/vbox_common.c

index 586937fa19dc4d1f4eadb4f1053cdfaa1c2d39e8..4493fe858232027fe8a547b423540031f688bb2b 100644 (file)
@@ -7374,9 +7374,8 @@ vboxDomainScreenshot(virDomainPtr dom,
 
     if (privileged) {
         cacheDir = g_strdup_printf("%s/cache/libvirt", LOCALSTATEDIR);
-    } else if (!(cacheDir = virGetUserCacheDirectory())) {
-        VBOX_RELEASE(machine);
-        return NULL;
+    } else {
+        cacheDir = virGetUserCacheDirectory();
     }
 
     tmp = g_strdup_printf("%s/vbox.screendump.XXXXXX", cacheDir);