]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: Intel: avs: Fix null-ptr-deref in avs_component_probe()
authorHenry Martin <bsdhenrymartin@gmail.com>
Wed, 2 Apr 2025 14:14:11 +0000 (22:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:45:39 +0000 (10:45 +0200)
[ Upstream commit 95f723cf141b95e3b3a5b92cf2ea98a863fe7275 ]

devm_kasprintf() returns NULL when memory allocation fails. Currently,
avs_component_probe() does not check for this case, which results in a
NULL pointer dereference.

Fixes: 739c031110da ("ASoC: Intel: avs: Provide support for fallback topology")
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Reviewed-by: Ethan Carter Edwards <ethan@ethancedwards.com>
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
Link: https://patch.msgid.link/20250402141411.44972-1-bsdhenrymartin@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/intel/avs/pcm.c

index bb1e77ac78e047151ac1cbf365530d1f320ac1ad..781019685b941f84df743958ea59c8a9240ea8d1 100644 (file)
@@ -808,7 +808,8 @@ static int avs_component_probe(struct snd_soc_component *component)
                else
                        mach->tplg_filename = devm_kasprintf(adev->dev, GFP_KERNEL,
                                                             "hda-generic-tplg.bin");
-
+               if (!mach->tplg_filename)
+                       return -ENOMEM;
                filename = kasprintf(GFP_KERNEL, "%s/%s", component->driver->topology_name_prefix,
                                     mach->tplg_filename);
                if (!filename)