]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/appletbdrm: Use kvzalloc for big allocations
authorSasha Finkelstein <k@chaosmail.tech>
Mon, 20 Apr 2026 12:17:43 +0000 (14:17 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 27 Apr 2026 09:33:01 +0000 (11:33 +0200)
This driver is attached to a ~2000x80 screen, which is a lot more than
a single page. This causes out of memory errors in some rare cases.

Reported-by: soopyc <cassie@soopy.moe>
Closes: https://github.com/t2linux/fedora/issues/51
Signed-off-by: Sasha Finkelstein <k@chaosmail.tech>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Aditya Garg <gargaditya08@live.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 0670c2f56e45 ("drm/tiny: add driver for Apple Touch Bars in x86 Macs")
Cc: <stable@vger.kernel.org> # v6.15+
Link: https://patch.msgid.link/20260420-x86-tb-vmalloc-v1-1-7757ff657223@chaosmail.tech
drivers/gpu/drm/tiny/appletbdrm.c

index 3bae91d7eefed706fb6305b7a8053a8c9d03952a..278bb23fe4c8d05e7ee515246a45acb30fca9ada 100644 (file)
@@ -353,7 +353,7 @@ static int appletbdrm_primary_plane_helper_atomic_check(struct drm_plane *plane,
                       frames_size +
                       sizeof(struct appletbdrm_fb_request_footer), 16);
 
-       appletbdrm_state->request = kzalloc(request_size, GFP_KERNEL);
+       appletbdrm_state->request = kvzalloc(request_size, GFP_KERNEL);
 
        if (!appletbdrm_state->request)
                return -ENOMEM;
@@ -543,7 +543,7 @@ static void appletbdrm_primary_plane_destroy_state(struct drm_plane *plane,
 {
        struct appletbdrm_plane_state *appletbdrm_state = to_appletbdrm_plane_state(state);
 
-       kfree(appletbdrm_state->request);
+       kvfree(appletbdrm_state->request);
        kfree(appletbdrm_state->response);
 
        __drm_gem_destroy_shadow_plane_state(&appletbdrm_state->base);