FILS: Do not try to add PMKSA cache entry if caching is disabled

This gets rid of a confusing error message "FILS: Failed to add PMKSA
cache entry based on ERP" for cases where PMKSA caching is disabled in
hostapd (disable_pmksa_caching=1). Functionality remains unchanged,
i.e., no cache entry was added before this change either.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
index 2e01530b20fccc256257957502c9b80e82ad1f7b..eee4683960644fc6389c601169f2cf38ebf7816b 100644 (file)
--- a/src/ap/ieee802_11.c
+++ b/src/ap/ieee802_11.c
@@ -1753,7 +1753,8 @@ prepare_auth_resp_fils(struct hostapd_data *hapd,
                        }
 
                        sta->fils_erp_pmkid_set = 0;
-                       if (wpa_auth_pmksa_add2(
+                       if (!hapd->conf->disable_pmksa_caching &&
+                           wpa_auth_pmksa_add2(
                                    hapd->wpa_auth, sta->addr,
                                    pmk, pmk_len,
                                    sta->fils_erp_pmkid,