]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
kernel-yocto: quote kconfig mode check
authorBruce Ashfield <bruce.ashfield@windriver.com>
Thu, 24 Apr 2014 18:09:39 +0000 (14:09 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 6 May 2014 16:59:07 +0000 (17:59 +0100)
We allow inheriting recipes to control the kconfig mode used by merge_config.sh
via the KCONFIG_MODE variable. An error crept into the variable reference, and
since it is not quoted, the true condition always runs.

The result is that operations without an explicit kconfig mode cannot trigger
allnoconfig for defconfig builds, which can result in some options being
dropped from the final .config.

Quoting the reference allows it to evaluate properly.

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
meta/classes/kernel-yocto.bbclass

index 53bc6d443cdb2eb2d30128c99af838bc5f83b092..6010dc94e026ec4a455f3768ad56c886bc6625eb 100644 (file)
@@ -241,7 +241,7 @@ do_kernel_configme() {
        echo "[INFO] doing kernel configme"
        export KMETA=${KMETA}
 
-       if [ -n ${KCONFIG_MODE} ]; then
+       if [ -n "${KCONFIG_MODE}" ]; then
                configmeflags=${KCONFIG_MODE}
        else
                # If a defconfig was passed, use =n as the baseline, which is achieved