]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
declance: Include the offending address with DMA errors
authorMaciej W. Rozycki <macro@orcam.me.uk>
Sun, 29 Mar 2026 18:07:41 +0000 (19:07 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 1 Apr 2026 02:32:41 +0000 (19:32 -0700)
The address latched in the I/O ASIC LANCE DMA Pointer Register uses the
TURBOchannel bus address encoding and therefore bits 33:29 of location
referred occupy bits 4:0, bits 28:2 are left-shifted by 3, and bits 1:0
are hardwired to zero.  In reality no TURBOchannel system exceeds 1GiB
of RAM though, so the address reported will always fit in 8 hex digits.

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
Link: https://patch.msgid.link/alpine.DEB.2.21.2603291839220.60268@angie.orcam.me.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amd/declance.c

index 24aa4803b4ae1a5af47131652ed0c651c3e4e6b0..c7d47ca603a8ad441ef7b3c8582be21feb3a1da7 100644 (file)
@@ -726,8 +726,10 @@ out:
 static irqreturn_t lance_dma_merr_int(int irq, void *dev_id)
 {
        struct net_device *dev = dev_id;
+       u64 ldp = ioasic_read(IO_REG_LANCE_DMA_P);
 
-       pr_err_ratelimited("%s: DMA error\n", dev->name);
+       pr_err_ratelimited("%s: DMA error at %#010llx\n", dev->name,
+                          (ldp & 0x1f) << 29 | (ldp & 0xffffffe0) >> 3);
        return IRQ_HANDLED;
 }