]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
perf/cxlpmu: Replace IRQF_ONESHOT with IRQF_NO_THREAD
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 28 Jan 2026 09:55:34 +0000 (10:55 +0100)
committerWill Deacon <will@kernel.org>
Wed, 28 Jan 2026 13:06:03 +0000 (13:06 +0000)
Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.
The flag also disallows force-threading of the primary handler and the
irq-core will warn about this.

The intention here was probably not allowing forced-threading.

Replace IRQF_ONESHOT with IRQF_NO_THREAD.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/cxl_pmu.c

index d094030220bf258fffa05f66dec59b8ce5535927..68a54d97d2a8af1a50eb7e6d2b8a4fe0357e07ac 100644 (file)
@@ -877,7 +877,7 @@ static int cxl_pmu_probe(struct device *dev)
        if (!irq_name)
                return -ENOMEM;
 
-       rc = devm_request_irq(dev, irq, cxl_pmu_irq, IRQF_SHARED | IRQF_ONESHOT,
+       rc = devm_request_irq(dev, irq, cxl_pmu_irq, IRQF_SHARED | IRQF_NO_THREAD,
                              irq_name, info);
        if (rc)
                return rc;