]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
samba_kcc: drop all connections from non-existent DSAs
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 15 Jun 2017 21:16:16 +0000 (09:16 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Fri, 23 Jun 2017 00:25:26 +0000 (02:25 +0200)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
python/samba/kcc/__init__.py

index f5444d4bcbd28bbfb06f922e4218a69c7e605f5e..2c545c18a7003380581a8b1dbbf9b71bce933a8d 100644 (file)
@@ -541,8 +541,9 @@ class KCC(object):
                 if s_dnstr not in local_dsas:
                     from_dsa = self.get_dsa(s_dnstr)
                     # Samba ONLY: ISTG removes connections to dead DCs
-                    if from_dsa is None and '\\0ADEL' in s_dnstr:
-                        logger.info("DSA appears deleted, removing connection %s" % s_dnstr)
+                    if from_dsa is None or '\\0ADEL' in s_dnstr:
+                        logger.info("DSA appears deleted, removing connection %s"
+                                    % s_dnstr)
                         cn.to_be_deleted = True
                         continue
                     connections_and_dsas.append((cn, dsa, from_dsa))