]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: drop vb2_ops_wait_prepare/finish
authorHans Verkuil <hverkuil@xs4all.nl>
Tue, 28 Jan 2025 15:05:02 +0000 (16:05 +0100)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 4 Feb 2025 14:12:34 +0000 (06:12 -0800)
Since commit 88785982a19d ("media: vb2: use lock if wait_prepare/finish
are NULL") it is no longer needed to set the wait_prepare/finish
vb2_ops callbacks as long as the lock field in vb2_queue is set.

Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,
we can safely drop these callbacks.

This simplifies the code and this is a step towards the goal of deleting
these callbacks.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Link: https://lore.kernel.org/r/ec811552-6014-43d4-9fcc-2ac729a8b08e@xs4all.nl
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_f54.c
drivers/input/touchscreen/atmel_mxt_ts.c
drivers/input/touchscreen/sur40.c

index 5c3da910b5b2ce1201e5e05626786f9dc750e4f0..ac4041a69fcd3acf766ac8189ea0ecccb9b7ac93 100644 (file)
@@ -372,8 +372,6 @@ static const struct vb2_ops rmi_f54_queue_ops = {
        .queue_setup            = rmi_f54_queue_setup,
        .buf_queue              = rmi_f54_buffer_queue,
        .stop_streaming         = rmi_f54_stop_streaming,
-       .wait_prepare           = vb2_ops_wait_prepare,
-       .wait_finish            = vb2_ops_wait_finish,
 };
 
 static const struct vb2_queue rmi_f54_queue = {
index 3ddabc5a2c999b2ed14353fb391552248e86b8ad..322d5a3d40a0933f1e1c290e906258a874bcf4b2 100644 (file)
@@ -2535,8 +2535,6 @@ fault:
 static const struct vb2_ops mxt_queue_ops = {
        .queue_setup            = mxt_queue_setup,
        .buf_queue              = mxt_buffer_queue,
-       .wait_prepare           = vb2_ops_wait_prepare,
-       .wait_finish            = vb2_ops_wait_finish,
 };
 
 static const struct vb2_queue mxt_queue = {
index 8365a2ac6fce65aeedc72c187053fcdaea6720a4..7b3b10cbfcfc44eabd56a4a39551c44eed730de8 100644 (file)
@@ -1108,8 +1108,6 @@ static const struct vb2_ops sur40_queue_ops = {
        .buf_queue              = sur40_buffer_queue,
        .start_streaming        = sur40_start_streaming,
        .stop_streaming         = sur40_stop_streaming,
-       .wait_prepare           = vb2_ops_wait_prepare,
-       .wait_finish            = vb2_ops_wait_finish,
 };
 
 static const struct vb2_queue sur40_queue = {