]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath12k: remove redundant vif settings during link interface creation
authorAditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Tue, 4 Feb 2025 17:05:09 +0000 (22:35 +0530)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Tue, 11 Feb 2025 15:27:09 +0000 (07:27 -0800)
Currently, vif level settings are done in ath12k_mac_assign_link_vif() as
well as in ath12k_mac_op_add_interface(). Since it is vif level settings,
doing this on per link does not make sense and it contributes to redundant
code. Get rid of this redundant code from ath12k_mac_assign_link_vif().

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1.97421.5 # Nicolas Escande

Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Signed-off-by: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Tested-by: Nicolas Escande <nico.escande@gmail.com>
Link: https://patch.msgid.link/20250204-unlink_link_arvif_from_chanctx-v2-3-764fb5973c1a@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/mac.c

index 664b13c259654628ba693d3528ad662a63401c0f..7168b268b4a10a0b956b251cab18aaac848b6c69 100644 (file)
@@ -4023,13 +4023,6 @@ static struct ath12k_link_vif *ath12k_mac_assign_link_vif(struct ath12k_hw *ah,
                       sizeof(arvif->bitrate_mask.control[i].vht_mcs));
        }
 
-       /* Allocate Default Queue now and reassign during actual vdev create */
-       vif->cab_queue = ATH12K_HW_DEFAULT_QUEUE;
-       for (i = 0; i < ARRAY_SIZE(vif->hw_queue); i++)
-               vif->hw_queue[i] = ATH12K_HW_DEFAULT_QUEUE;
-
-       vif->driver_flags |= IEEE80211_VIF_SUPPORTS_UAPSD;
-
        rcu_assign_pointer(ahvif->link[arvif->link_id], arvif);
        ahvif->links_map |= BIT(link_id);
        synchronize_rcu();