]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vz: dont remove domain from list on client object error
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Tue, 14 Jun 2016 08:45:58 +0000 (11:45 +0300)
committerMaxim Nestratov <mnestratov@virtuozzo.com>
Tue, 19 Jul 2016 02:31:17 +0000 (05:31 +0300)
After domain is in the domains list let's keep it there. This
is approach taken by qemu driver and vz vzDomainMigrateFinish3Params too.
It quite reasonable, driver domain object is fully constructed and
can be discovered by client later.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
src/vz/vz_driver.c

index 9a71c3b6a9951046684965802eac0953ba3f9957..d7e768c0ec641dbeadc528694449418dcb8d17af 100644 (file)
@@ -791,12 +791,8 @@ vzDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int flags)
  cleanup:
     if (olddom)
         virObjectUnlock(olddom);
-    if (newdom) {
-        if (!retdom)
-             virDomainObjListRemove(driver->domains, newdom);
-        else
-             virObjectUnlock(newdom);
-    }
+    if (newdom)
+        virObjectUnlock(newdom);
     virDomainDefFree(def);
     return retdom;
 }