]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core: drop unused errno from debug message 40950/head
authorFrantisek Sumsal <frantisek@sumsal.cz>
Wed, 4 Mar 2026 19:56:30 +0000 (20:56 +0100)
committerFrantisek Sumsal <frantisek@sumsal.cz>
Thu, 5 Mar 2026 09:27:59 +0000 (10:27 +0100)
And properly guard unset parameters.

src/core/varlink-unit.c

index 261ade0e9a3c617fbf51c65f7aa1e5e136d877df..95ac16cb859167af73b2a374e15351517f12a1d7 100644 (file)
@@ -408,13 +408,11 @@ static void unit_lookup_parameters_done(UnitLookupParameters *p) {
 }
 
 static int varlink_error_conflict_lookup_parameters(sd_varlink *v, const UnitLookupParameters *p) {
-        log_debug_errno(
-                        ESRCH,
-                        "Searching unit by lookup parameters name='%s' pid="PID_FMT" cgroup='%s' invocationID='%s' resulted in multiple different units",
-                        p->name,
-                        p->pidref.pid,
-                        p->cgroup,
-                        sd_id128_is_null(p->invocation_id) ? "" : SD_ID128_TO_UUID_STRING(p->invocation_id));
+        log_debug("Searching unit by lookup parameters name='%s' pid='"PID_FMT"' cgroup='%s' invocationID='%s' resulted in multiple different units",
+                  strnull(p->name),
+                  pidref_is_set(&p->pidref) ? p->pidref.pid : 0,
+                  strnull(p->cgroup),
+                  sd_id128_is_null(p->invocation_id) ? "" : SD_ID128_TO_UUID_STRING(p->invocation_id));
 
         return varlink_error_no_such_unit(v, /* name= */ NULL);
 }