coverity: fix dereference NULL return value

also break once we have found root, no need to search the rest of the mounts

Changelog: May 6: Serge: don't add the break.  (see m-l)

Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>

diff --git a/src/lxc/conf.c b/src/lxc/conf.c
index 125e8a6d2107fb88351b1fa9dff5812beeceedda..827626f1d7f86608f907330de548b344a057bd21 100644 (file)
--- a/src/lxc/conf.c
+++ b/src/lxc/conf.c
@@ -1067,10 +1067,11 @@ int detect_shared_rootfs(void)
                if (strcmp(p+1, "/") == 0) {
                        // this is '/'.  is it shared?
                        p = index(p2+1, ' ');
-                       if (strstr(p, "shared:")) {
+                       if (p && strstr(p, "shared:")) {
                                fclose(f);
                                return 1;
                        }
+                       break;
                }
        }
        fclose(f);