]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: Call trace_sock_exceed_buf_limit() for memcg failure with SK_MEM_RECV.
authorKuniyuki Iwashima <kuniyu@google.com>
Fri, 15 Aug 2025 20:16:12 +0000 (20:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Nov 2025 20:37:04 +0000 (15:37 -0500)
[ Upstream commit 9d85c565a7b7c78b732393c02bcaa4d5c275fe58 ]

Initially, trace_sock_exceed_buf_limit() was invoked when
__sk_mem_raise_allocated() failed due to the memcg limit or the
global limit.

However, commit d6f19938eb031 ("net: expose sk wmem in
sock_exceed_buf_limit tracepoint") somehow suppressed the event
only when memcg failed to charge for SK_MEM_RECV, although the
memcg failure for SK_MEM_SEND still triggers the event.

Let's restore the event for SK_MEM_RECV.

Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
Link: https://patch.msgid.link/20250815201712.1745332-5-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/sock.c

index e21348ead7e76491eda205b08cf8dea6de6988b5..1382bddcbaff438f378bcfbdb04ecc062534ddb5 100644 (file)
@@ -3336,8 +3336,7 @@ suppress_allocation:
                }
        }
 
-       if (kind == SK_MEM_SEND || (kind == SK_MEM_RECV && charged))
-               trace_sock_exceed_buf_limit(sk, prot, allocated, kind);
+       trace_sock_exceed_buf_limit(sk, prot, allocated, kind);
 
        sk_memory_allocated_sub(sk, amt);