static int filter_init(ap_filter_t *f)
{
ap_filter_provider_t *p;
- int err = OK;
+ int err;
ap_filter_rec_t *filter = f->frec;
f->ctx = apr_pcalloc(f->r->pool, sizeof(harness_ctx));
for (p = filter->providers; p; p = p->next) {
if (p->frec->filter_init_func) {
- if (err = p->frec->filter_init_func(f), err != OK) {
+ if ((err = p->frec->filter_init_func(f)) != OK) {
ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, f->r,
"filter_init for %s failed", p->frec->name);
- break; /* if anyone errors out here, so do we */
+ return err; /* if anyone errors out here, so do we */
}
}
}
- return err;
+ return OK;
}
static ap_out_filter_func filter_lookup(request_rec *r, ap_filter_rec_t *filter)