fix ITS#1364, value_add empty value bug

diff --git a/CHANGES b/CHANGES
index 882aa0ae96e68bb4c79eef3eef83c8190b61d613..b6bf61ea87a955b9bdc441cc4a701ea86324fa52 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -5,6 +5,7 @@ OpenLDAP 2.0.19 Engineering
        Fixed back-ldbm not filter indexing
        Fixed back-passwd e_ndn bug
        Fixed slapd suffix "" bugs (ITS#1430)
+       Fixed slapd zero length replace bug
        Fixed various memory leaks
        Updated slapd emfile/enfile handling
        Build environment

diff --git a/servers/slapd/value.c b/servers/slapd/value.c
index e4b9ee0ed6c4ea05ae9e61947c6f629cf385febd..1b8dfd6e2514c27f4ef2f5c767f1d1d3667f166d 100644 (file)
--- a/servers/slapd/value.c
+++ b/servers/slapd/value.c
@@ -41,10 +41,8 @@ value_add(
        }
 
        for ( i = 0, j = 0; i < nn; i++ ) {
-               if ( addvals[i]->bv_len > 0 ) {
-                       (*vals)[n + j] = ber_bvdup( addvals[i] );
-                       if( (*vals)[n + j++] == NULL ) break;
-               }
+               (*vals)[n + j] = ber_bvdup( addvals[i] );
+               if( (*vals)[n + j++] == NULL ) break;
        }
        (*vals)[n + j] = NULL;