]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
xen/usb: Constify struct hc_driver
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 26 Oct 2025 10:51:04 +0000 (11:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Oct 2025 14:35:15 +0000 (15:35 +0100)
'struct hc_driver' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text    data     bss     dec     hex filename
  52065   23176     256   75497   126e9 drivers/usb/host/xen-hcd.o

After:
=====
   text    data     bss     dec     hex filename
  52897   22344     256   75497   126e9 drivers/usb/host/xen-hcd.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://patch.msgid.link/63241c9e857646d895ce615b998d41ee4829f9e3.1761475831.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xen-hcd.c

index 1c2a95fe41e59145e348791b9e39ea829c3502fb..0a94d302911aa1d3387b52c33d90641f78ca8b54 100644 (file)
@@ -1388,7 +1388,7 @@ static int xenhcd_get_frame(struct usb_hcd *hcd)
        return 0;
 }
 
-static struct hc_driver xenhcd_usb20_hc_driver = {
+static const struct hc_driver xenhcd_usb20_hc_driver = {
        .description = "xen-hcd",
        .product_desc = "Xen USB2.0 Virtual Host Controller",
        .hcd_priv_size = sizeof(struct xenhcd_info),
@@ -1413,7 +1413,7 @@ static struct hc_driver xenhcd_usb20_hc_driver = {
 #endif
 };
 
-static struct hc_driver xenhcd_usb11_hc_driver = {
+static const struct hc_driver xenhcd_usb11_hc_driver = {
        .description = "xen-hcd",
        .product_desc = "Xen USB1.1 Virtual Host Controller",
        .hcd_priv_size = sizeof(struct xenhcd_info),