]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:winbindd: Add missing newlines to logging messages
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 7 Aug 2023 04:51:21 +0000 (16:51 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 8 Aug 2023 04:39:38 +0000 (04:39 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/winbindd/idmap_autorid_tdb.c
source3/winbindd/idmap_ldap.c
source3/winbindd/winbindd_cache.c
source3/winbindd/winbindd_cm.c
source3/winbindd/winbindd_dual.c
source3/winbindd/winbindd_dual_ndr.c
source3/winbindd/winbindd_pam.c

index fb195367da6bc2e06a6af54988c9cec2e23221a0..6c76764076a5cc0b86ae20be8bfbb4569fdd7231 100644 (file)
@@ -100,12 +100,12 @@ static NTSTATUS idmap_autorid_addrange_action(struct db_context *db,
        requested_rangenum = range->rangenum;
 
        if (db == NULL) {
-               DEBUG(3, ("Invalid database argument: NULL"));
+               DEBUG(3, ("Invalid database argument: NULL\n"));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
        if (range == NULL) {
-               DEBUG(3, ("Invalid range argument: NULL"));
+               DEBUG(3, ("Invalid range argument: NULL\n"));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
@@ -355,7 +355,7 @@ static NTSTATUS idmap_autorid_getrange_int(struct db_context *db,
 
        status = idmap_autorid_loadconfig(db, &globalcfg);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(1, ("Failed to read global configuration"));
+               DEBUG(1, ("Failed to read global configuration\n"));
                goto done;
        }
        range->low_id = globalcfg.minvalue
index ee12f04c1a9da0f435b3083ae708b5d4aef4e285..0b0d82bba36922fdcd027c3020c5b9399355cb15 100644 (file)
@@ -942,7 +942,7 @@ again:
                }
                filter = talloc_asprintf_append_buffer(filter, "))");
                CHECK_ALLOC_DONE(filter);
-               DEBUG(10, ("Filter: [%s]", filter));
+               DEBUG(10, ("Filter: [%s]\n", filter));
        } else {
                bidx = 0;
                idx = 1;
@@ -1006,7 +1006,7 @@ again:
                map = idmap_find_map_by_sid(&ids[bidx], &sid);
                if (!map) {
                        DEBUG(2, ("WARNING: couldn't find entry sid (%s) "
-                                 "in ids", sidstr));
+                                 "in ids\n", sidstr));
                        TALLOC_FREE(sidstr);
                        continue;
                }
index a16eaa5021987aa3e743deb7b94ff00a76fd573b..ca2341ef4564ede9935f0643259ec880bd7aa70e 100644 (file)
@@ -3251,7 +3251,7 @@ bool initialize_winbindd_cache(void)
                }
 
                if (unlink(db_path) == -1) {
-                       DBG_ERR("initialize_winbindd_cache: unlink %s failed %s ",
+                       DBG_ERR("initialize_winbindd_cache: unlink %s failed %s\n",
                                db_path,
                                strerror(errno) );
                        TALLOC_FREE(db_path);
index 9f56596669b6ce432b72533e151a0f9cd21cce20..2fab9ceadf76aab0095b39fe8107241d9433f178 100644 (file)
@@ -3326,7 +3326,7 @@ void winbind_msg_ip_dropped(struct messaging_context *msg_ctx,
                 */
                slash = strchr(addr, '/');
                if (slash == NULL) {
-                       DEBUG(1, ("invalid msg_ip_dropped message: %s",
+                       DEBUG(1, ("invalid msg_ip_dropped message: %s\n",
                                  addr));
                        return;
                }
index 36562ab10b8d35ccd15c8a60a1c1d6307a4fb0d8..dadae1d3edacc1091f75eea3525791d3eb1edd5f 100644 (file)
@@ -1252,7 +1252,7 @@ static bool calculate_next_machine_pwd_change(const char *domain,
                                            NULL);
 
        if (pw == NULL) {
-               DEBUG(0,("cannot fetch own machine password ????"));
+               DEBUG(0,("cannot fetch own machine password ????\n"));
                return false;
        }
 
@@ -1984,7 +1984,7 @@ bool winbindd_setup_sig_term_handler(bool parent)
                               winbindd_sig_term_handler,
                               is_parent);
        if (!se) {
-               DEBUG(0,("failed to setup SIGTERM handler"));
+               DEBUG(0,("failed to setup SIGTERM handler\n"));
                talloc_free(is_parent);
                return false;
        }
@@ -1995,7 +1995,7 @@ bool winbindd_setup_sig_term_handler(bool parent)
                               winbindd_sig_term_handler,
                               is_parent);
        if (!se) {
-               DEBUG(0,("failed to setup SIGINT handler"));
+               DEBUG(0,("failed to setup SIGINT handler\n"));
                talloc_free(is_parent);
                return false;
        }
@@ -2006,7 +2006,7 @@ bool winbindd_setup_sig_term_handler(bool parent)
                               winbindd_sig_term_handler,
                               is_parent);
        if (!se) {
-               DEBUG(0,("failed to setup SIGINT handler"));
+               DEBUG(0,("failed to setup SIGINT handler\n"));
                talloc_free(is_parent);
                return false;
        }
index 48b5297f57e237300169703f9c411046d6d38888..cf54d998891b6aabf8ca841f3c34eba9dffcbce0 100644 (file)
@@ -465,14 +465,14 @@ static NTSTATUS set_remote_addresses(struct dcesrv_connection *conn,
        ret = getpeername(sock, sar, &sa_len);
        if (ret != 0) {
                status = map_nt_error_from_unix(ret);
-               DBG_ERR("getpeername failed: %s", nt_errstr(status));
+               DBG_ERR("getpeername failed: %s\n", nt_errstr(status));
                return status;
        }
 
        ret = tsocket_address_bsd_from_sockaddr(conn, sar, sa_len, &remote);
        if (ret != 0) {
                status = map_nt_error_from_unix(ret);
-               DBG_ERR("tsocket_address_bsd_from_sockaddr failed: %s",
+               DBG_ERR("tsocket_address_bsd_from_sockaddr failed: %s\n",
                        nt_errstr(status));
                return status;
        }
@@ -481,14 +481,14 @@ static NTSTATUS set_remote_addresses(struct dcesrv_connection *conn,
        ret = getsockname(sock, sar, &sa_len);
        if (ret != 0) {
                status = map_nt_error_from_unix(ret);
-               DBG_ERR("getsockname failed: %s", nt_errstr(status));
+               DBG_ERR("getsockname failed: %s\n", nt_errstr(status));
                return status;
        }
 
        ret = tsocket_address_bsd_from_sockaddr(conn, sar, sa_len, &local);
        if (ret != 0) {
                status = map_nt_error_from_unix(ret);
-               DBG_ERR("tsocket_address_bsd_from_sockaddr failed: %s",
+               DBG_ERR("tsocket_address_bsd_from_sockaddr failed: %s\n",
                        nt_errstr(status));
                return status;
        }
@@ -541,7 +541,7 @@ enum winbindd_result winbindd_dual_ndrcmd(struct winbindd_domain *domain,
 
        mem_ctx = talloc_stackframe();
        if (mem_ctx == NULL) {
-               DBG_ERR("No memory");
+               DBG_ERR("No memory\n");
                return WINBINDD_ERROR;
        }
 
index 66d5b4a5a7b29f2ba32984d2ebac11fa3ee0995e..9efbeb08d18d83fa757d31d674a498e23dcea037 100644 (file)
@@ -2169,7 +2169,7 @@ static void log_authentication(
                client_name,
                client_pid);
        if (ui->auth_description == NULL) {
-               DBG_ERR("OOM Unable to create auth_description");
+               DBG_ERR("OOM Unable to create auth_description\n");
        }
        ui->client.account_name = user_name;
        ui->client.domain_name = domain_name;