]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tests: esxutils: reduce variable scope in testEscapeDatastoreItem
authorJán Tomko <jtomko@redhat.com>
Fri, 3 Sep 2021 18:16:15 +0000 (20:16 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 8 Sep 2021 13:31:01 +0000 (15:31 +0200)
Also use g_auto.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
tests/esxutilstest.c

index bfb35fa356a1f168abee1338870aefd4177776c9..d537da3011d9ef59326fa548dda7ac8b1638e3b0 100644 (file)
@@ -161,23 +161,19 @@ static int
 testEscapeDatastoreItem(const void *data G_GNUC_UNUSED)
 {
     size_t i;
-    char *escaped = NULL;
 
     for (i = 0; i < G_N_ELEMENTS(datastoreItems); ++i) {
-        VIR_FREE(escaped);
+        g_autofree char *escaped = NULL;
 
         escaped = esxUtil_EscapeDatastoreItem(datastoreItems[i].string);
 
         if (escaped == NULL)
             return -1;
 
-        if (STRNEQ(datastoreItems[i].escaped, escaped)) {
-            VIR_FREE(escaped);
+        if (STRNEQ(datastoreItems[i].escaped, escaped))
             return -1;
-        }
     }
 
-    VIR_FREE(escaped);
     return 0;
 }