]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
Fix memory leak in mod_ssl from internal SSL library allocations
authorWilliam A. Rowe Jr <wrowe@apache.org>
Tue, 29 Oct 2002 21:12:34 +0000 (21:12 +0000)
committerWilliam A. Rowe Jr <wrowe@apache.org>
Tue, 29 Oct 2002 21:12:34 +0000 (21:12 +0000)
  within SSL_get_peer_certificate and X509_get_pubkey.

Submitted by: Zvi Har'El <rl@math.technion.ac.il>
Reviewed by: Madhusudan Mathihalli <madhusudan_mathihalli@hp.com>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97344 13f79535-47bb-0310-9956-ffa450edef68

CHANGES
modules/ssl/ssl_engine_init.c

diff --git a/CHANGES b/CHANGES
index d208dce7952e0a4dd0f3f35a1a84b18710e5f5a5..db36e11645d09ec201370639c6eeb95f06b9a3bc 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,5 +1,10 @@
 Changes with Apache 2.0.44
 
+  *) Fix memory leak in mod_ssl from internal SSL library allocations
+     within SSL_get_peer_certificate and X509_get_pubkey.
+     [Zvi Har'El <rl@math.technion.ac.il>
+      Madhusudan Mathihalli <madhusudan_mathihalli@hp.com>].
+
   *) mod_ssl uses free() inappropriately in several places, to free
      memory which has been previously allocated inside OpenSSL.
      Such memory should be freed with OPENSSL_free(), not with free().
index bf63baf4c1ad510d529ab2c3605757de79cccefb..b387ccc94476db2fc8a462b4ea2387b8fb89a0f4 100644 (file)
@@ -807,6 +807,7 @@ static int ssl_server_import_key(server_rec *s,
             ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
                     "Copying DSA parameters from private key to certificate");
             ssl_log_ssl_error(APLOG_MARK, APLOG_ERR, s);
+            EVP_PKEY_free(pubkey);
         }
     }