]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drivers/base/node: remove register_memory_blocks_under_node() function call from...
authorDonet Tom <donettom@linux.ibm.com>
Wed, 28 May 2025 17:18:02 +0000 (12:18 -0500)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 10 Jul 2025 05:41:59 +0000 (22:41 -0700)
register_one_node() is now only called via cpu_up() →
__try_online_node() during CPU hotplug operations to online a node.

At this stage, the node has not yet had any memory added.  As a result,
there are no memory blocks to walk or register, so calling
register_memory_blocks_under_node() is unnecessary.

Therefore, the call to register_memory_blocks_under_node() has been
removed from register_one_node().

Link: https://lkml.kernel.org/r/ecf07075b1a41015fcf58823997d5c2ed7b8c18f.1748452242.git.donettom@linux.ibm.com
Signed-off-by: Donet Tom <donettom@linux.ibm.com>
Acked-by: Oscar Salvador <osalvador@suse.de>
Acked-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Acked-by: David Hildenbrand <david@redhat.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/node.h

index 485370f3bc1771a563a6260ae762130ecb0cc1ea..b15de78e04087fc300392a46a2a5339902c72b7e 100644 (file)
@@ -134,21 +134,7 @@ extern int __register_one_node(int nid);
 /* Registers an online node */
 static inline int register_one_node(int nid)
 {
-       int error = 0;
-
-       if (node_online(nid)) {
-               struct pglist_data *pgdat = NODE_DATA(nid);
-               unsigned long start_pfn = pgdat->node_start_pfn;
-               unsigned long end_pfn = start_pfn + pgdat->node_spanned_pages;
-
-               error = __register_one_node(nid);
-               if (error)
-                       return error;
-               register_memory_blocks_under_node(nid, start_pfn, end_pfn,
-                                                 MEMINIT_EARLY);
-       }
-
-       return error;
+       return __register_one_node(nid);
 }
 
 extern void unregister_one_node(int nid);