clk: tests: add clk_hw_get_dev() and clk_hw_get_of_node() tests

Add kunit test suites clk_hw_get_dev() and clk_hw_get_of_node()
for clocks registered with clk_hw_register() and of_clk_hw_register()

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20250417-clk-hw-get-helpers-v1-2-7743e509612a@baylibre.com
Reviewed-by: Brian Masney <bmasney@redhat.com>
[sboyd@kernel.org: Drop genparams, rename tests, drop inits,
combine suites, add test for non-DT platform device]
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index 42867cd37c33d2ca000b58375874c3e20ef479d4..862c3eefa5b5bdbf77c049e06fc195a6da772d4a 100644 (file)
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -18,6 +18,7 @@ clk-test-y                    := clk_test.o \
                                   kunit_clk_assigned_rates_without_consumer.dtbo.o \
                                   kunit_clk_assigned_rates_zero.dtbo.o \
                                   kunit_clk_assigned_rates_zero_consumer.dtbo.o \
+                                  kunit_clk_hw_get_dev_of_node.dtbo.o \
                                   kunit_clk_parent_data_test.dtbo.o
 obj-$(CONFIG_COMMON_CLK)       += clk-divider.o
 obj-$(CONFIG_COMMON_CLK)       += clk-fixed-factor.o

diff --git a/drivers/clk/clk_test.c b/drivers/clk/clk_test.c
index ac28c05d9c66dc57a628b9e49312513566a1cacf..042e632045bbeb65a575a41cda491d4ad1383ee8 100644 (file)
--- a/drivers/clk/clk_test.c
+++ b/drivers/clk/clk_test.c
@@ -3403,8 +3403,148 @@ static struct kunit_suite clk_assigned_rates_suite = {
        .init = clk_assigned_rates_test_init,
 };
 
+static const struct clk_init_data clk_hw_get_dev_of_node_init_data = {
+       .name = "clk_hw_get_dev_of_node",
+       .ops = &empty_clk_ops,
+};
+
+/*
+ * Test that a clk registered with a struct device returns the device from
+ * clk_hw_get_dev() and the node from clk_hw_get_of_node()
+ */
+static void clk_hw_register_dev_get_dev_returns_dev(struct kunit *test)
+{
+       struct device *dev;
+       struct clk_hw *hw;
+       static const struct of_device_id match_table[] = {
+               { .compatible = "test,clk-hw-get-dev-of-node" },
+               { }
+       };
+
+       KUNIT_ASSERT_EQ(test, 0, of_overlay_apply_kunit(test, kunit_clk_hw_get_dev_of_node));
+
+       dev = kunit_of_platform_driver_dev(test, match_table);
+
+       hw = kunit_kzalloc(test, sizeof(*hw), GFP_KERNEL);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, hw);
+
+       hw->init = &clk_hw_get_dev_of_node_init_data;
+       KUNIT_ASSERT_EQ(test, 0, clk_hw_register_kunit(test, dev, hw));
+
+       KUNIT_EXPECT_PTR_EQ(test, dev, clk_hw_get_dev(hw));
+       KUNIT_EXPECT_PTR_EQ(test, dev_of_node(dev), clk_hw_get_of_node(hw));
+}
+
+/*
+ * Test that a clk registered with a struct device that's not associated with
+ * an OF node returns the device from clk_hw_get_dev() and NULL from
+ * clk_hw_get_of_node()
+ */
+static void clk_hw_register_dev_no_node_get_dev_returns_dev(struct kunit *test)
+{
+       struct platform_device *pdev;
+       struct device *dev;
+       struct clk_hw *hw;
+
+       pdev = kunit_platform_device_alloc(test, "clk_hw_register_dev_no_node", -1);
+       KUNIT_ASSERT_NOT_NULL(test, pdev);
+       KUNIT_ASSERT_EQ(test, 0, kunit_platform_device_add(test, pdev));
+       dev = &pdev->dev;
+
+       hw = kunit_kzalloc(test, sizeof(*hw), GFP_KERNEL);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, hw);
+
+       hw->init = &clk_hw_get_dev_of_node_init_data;
+       KUNIT_ASSERT_EQ(test, 0, clk_hw_register_kunit(test, dev, hw));
+
+       KUNIT_EXPECT_PTR_EQ(test, dev, clk_hw_get_dev(hw));
+       KUNIT_EXPECT_PTR_EQ(test, NULL, clk_hw_get_of_node(hw));
+}
+
+/*
+ * Test that a clk registered without a struct device returns NULL from
+ * clk_hw_get_dev()
+ */
+static void clk_hw_register_NULL_get_dev_of_node_returns_NULL(struct kunit *test)
+{
+       struct clk_hw *hw;
+
+       hw = kunit_kzalloc(test, sizeof(*hw), GFP_KERNEL);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, hw);
+
+       hw->init = &clk_hw_get_dev_of_node_init_data;
+
+       KUNIT_ASSERT_EQ(test, 0, clk_hw_register_kunit(test, NULL, hw));
+
+       KUNIT_EXPECT_PTR_EQ(test, NULL, clk_hw_get_dev(hw));
+       KUNIT_EXPECT_PTR_EQ(test, NULL, clk_hw_get_of_node(hw));
+}
+
+/*
+ * Test that a clk registered with an of_node returns the node from
+ * clk_hw_get_of_node() and NULL from clk_hw_get_dev()
+ */
+static void of_clk_hw_register_node_get_of_node_returns_node(struct kunit *test)
+{
+       struct device_node *np;
+       struct clk_hw *hw;
+
+       hw = kunit_kzalloc(test, sizeof(*hw), GFP_KERNEL);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, hw);
+
+       KUNIT_ASSERT_EQ(test, 0, of_overlay_apply_kunit(test, kunit_clk_hw_get_dev_of_node));
+
+       np = of_find_compatible_node(NULL, NULL, "test,clk-hw-get-dev-of-node");
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, np);
+       of_node_put_kunit(test, np);
+
+       hw->init = &clk_hw_get_dev_of_node_init_data;
+       KUNIT_ASSERT_EQ(test, 0, of_clk_hw_register_kunit(test, np, hw));
+
+       KUNIT_EXPECT_PTR_EQ(test, NULL, clk_hw_get_dev(hw));
+       KUNIT_EXPECT_PTR_EQ(test, np, clk_hw_get_of_node(hw));
+}
+
+/*
+ * Test that a clk registered without an of_node returns the node from
+ * clk_hw_get_of_node() and clk_hw_get_dev()
+ */
+static void of_clk_hw_register_NULL_get_of_node_returns_NULL(struct kunit *test)
+{
+       struct clk_hw *hw;
+
+       hw = kunit_kzalloc(test, sizeof(*hw), GFP_KERNEL);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, hw);
+
+       hw->init = &clk_hw_get_dev_of_node_init_data;
+       KUNIT_ASSERT_EQ(test, 0, of_clk_hw_register_kunit(test, NULL, hw));
+
+       KUNIT_EXPECT_PTR_EQ(test, NULL, clk_hw_get_dev(hw));
+       KUNIT_EXPECT_PTR_EQ(test, NULL, clk_hw_get_of_node(hw));
+}
+
+static struct kunit_case clk_hw_get_dev_of_node_test_cases[] = {
+       KUNIT_CASE(clk_hw_register_dev_get_dev_returns_dev),
+       KUNIT_CASE(clk_hw_register_dev_no_node_get_dev_returns_dev),
+       KUNIT_CASE(clk_hw_register_NULL_get_dev_of_node_returns_NULL),
+       KUNIT_CASE(of_clk_hw_register_node_get_of_node_returns_node),
+       KUNIT_CASE(of_clk_hw_register_NULL_get_of_node_returns_NULL),
+       {}
+};
+
+/*
+ * Test suite to verify clk_hw_get_dev() and clk_hw_get_of_node() when clk
+ * registered with clk_hw_register() and of_clk_hw_register()
+ */
+static struct kunit_suite clk_hw_get_dev_of_node_test_suite = {
+       .name = "clk_hw_get_dev_of_node_test_suite",
+       .test_cases = clk_hw_get_dev_of_node_test_cases,
+};
+
+
 kunit_test_suites(
        &clk_assigned_rates_suite,
+       &clk_hw_get_dev_of_node_test_suite,
        &clk_leaf_mux_set_rate_parent_test_suite,
        &clk_test_suite,
        &clk_multiple_parents_mux_test_suite,

diff --git a/drivers/clk/kunit_clk_hw_get_dev_of_node.dtso b/drivers/clk/kunit_clk_hw_get_dev_of_node.dtso
new file mode 100644 (file)
index 0000000..760717d
--- /dev/null
+++ b/drivers/clk/kunit_clk_hw_get_dev_of_node.dtso
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
+/dts-v1/;
+/plugin/;
+
+&{/} {
+       kunit-clock-controller {
+               compatible = "test,clk-hw-get-dev-of-node";
+               #clock-cells = <0>;
+       };
+};