]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: Intel: sof_sdw: Fix unlikely uninitialized variable use in create_sdw_dailinks()
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Mon, 3 Mar 2025 06:55:52 +0000 (14:55 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Mar 2025 19:54:25 +0000 (12:54 -0700)
commit 4363f02a39e25e80e68039b4323c570b0848ec66 upstream.

Initialize current_be_id to 0 to handle the unlikely case when there are
no devices connected to a DAI.
In this case create_sdw_dailink() would return without touching the passed
pointer to current_be_id.

Found by gcc -fanalyzer

Fixes: 59bf457d8055 ("ASoC: intel: sof_sdw: Factor out SoundWire DAI creation")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://patch.msgid.link/20250303065552.78328-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/intel/boards/sof_sdw.c

index f5b0e809ae0667821ae7d7ac187b4737e98cec92..380fc3be8c932e255672c65a26ad83da7e485837 100644 (file)
@@ -871,7 +871,7 @@ static int create_sdw_dailinks(struct snd_soc_card *card,
 
        /* generate DAI links by each sdw link */
        while (sof_dais->initialised) {
-               int current_be_id;
+               int current_be_id = 0;
 
                ret = create_sdw_dailink(card, sof_dais, dai_links,
                                         &current_be_id, codec_conf);