TLS: sometimes TCP conn. handle might be NULL on when connecting

In some cases - in particular, in case of errors, NULL might be passed
to a connection callback instead of a handle that could have led to
an abort. This commit ensures that such a situation will not occur.

The issue was found when working on the loopmgr branch.

diff --git a/lib/isc/netmgr/tlsstream.c b/lib/isc/netmgr/tlsstream.c
index 69b867964b5c94281e8c380a1c61c684aa2e2e48..adde8e069a22eb6bbd8d6785b1a7b775787161df 100644 (file)
--- a/lib/isc/netmgr/tlsstream.c
+++ b/lib/isc/netmgr/tlsstream.c
@@ -951,13 +951,14 @@ tcp_connected(isc_nmhandle_t *handle, isc_result_t result, void *cbarg) {
        isc_nmhandle_t *tlshandle = NULL;
 
        REQUIRE(VALID_NMSOCK(tlssock));
-       REQUIRE(VALID_NMHANDLE(handle));
 
        tlssock->tid = isc_nm_tid();
        if (result != ISC_R_SUCCESS) {
                goto error;
        }
 
+       INSIST(VALID_NMHANDLE(handle));
+
        tlssock->iface = handle->sock->iface;
        tlssock->peer = handle->sock->peer;
        if (isc__nm_closing(tlssock)) {