drm/xe: Move Wa_15015404425 to use the new XE_DEVICE_WA macro

Move Wa_15015404425 to use the new implemented OOB macro XE_DEVICE_WA()

v2: rename from SoC to Device
v5: move workaround call back into the flush call
v6: remove redundant commenting

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
Link: https://lore.kernel.org/r/20250709221605.172516-6-matthew.s.atwood@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

diff --git a/drivers/gpu/drm/xe/xe_device_wa_oob.rules b/drivers/gpu/drm/xe/xe_device_wa_oob.rules
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..b7d12ea4d65c99e64518489316e08123f66b8093 100644 (file)
--- a/drivers/gpu/drm/xe/xe_device_wa_oob.rules
+++ b/drivers/gpu/drm/xe/xe_device_wa_oob.rules
@@ -0,0 +1 @@
+15015404425     PLATFORM(LUNARLAKE)

diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
index 751586d6806ad191d3bbf7007f97c00316865c78..e4db8d58ea2db383d165fd3fcd50a8da01eb3fe0 100644 (file)
--- a/drivers/gpu/drm/xe/xe_mmio.c
+++ b/drivers/gpu/drm/xe/xe_mmio.c
@@ -22,6 +22,9 @@
 #include "xe_macros.h"
 #include "xe_sriov.h"
 #include "xe_trace.h"
+#include "xe_wa.h"
+
+#include "generated/xe_device_wa_oob.h"
 
 static void tiles_fini(void *arg)
 {
@@ -167,7 +170,7 @@ static void mmio_flush_pending_writes(struct xe_mmio *mmio)
 #define DUMMY_REG_OFFSET       0x130030
        int i;
 
-       if (mmio->tile->xe->info.platform != XE_LUNARLAKE)
+       if (!XE_DEVICE_WA(mmio->tile->xe, 15015404425))
                return;
 
        /* 4 dummy writes */
@@ -180,7 +183,6 @@ u8 xe_mmio_read8(struct xe_mmio *mmio, struct xe_reg reg)
        u32 addr = xe_mmio_adjusted_addr(mmio, reg.addr);
        u8 val;
 
-       /* Wa_15015404425 */
        mmio_flush_pending_writes(mmio);
 
        val = readb(mmio->regs + addr);
@@ -194,7 +196,6 @@ u16 xe_mmio_read16(struct xe_mmio *mmio, struct xe_reg reg)
        u32 addr = xe_mmio_adjusted_addr(mmio, reg.addr);
        u16 val;
 
-       /* Wa_15015404425 */
        mmio_flush_pending_writes(mmio);
 
        val = readw(mmio->regs + addr);
@@ -221,7 +222,6 @@ u32 xe_mmio_read32(struct xe_mmio *mmio, struct xe_reg reg)
        u32 addr = xe_mmio_adjusted_addr(mmio, reg.addr);
        u32 val;
 
-       /* Wa_15015404425 */
        mmio_flush_pending_writes(mmio);
 
        if (!reg.vf && IS_SRIOV_VF(mmio->tile->xe))