]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: ccs-pll: Print a debug message when VT tree calculation fails
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Sun, 27 Apr 2025 22:13:32 +0000 (01:13 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Tue, 6 May 2025 11:06:29 +0000 (13:06 +0200)
When the VT tree calculation fails to find a valid pre-divider, the
ccs_pll_calculate_vt_tree() function returns an error silently, and the
caller doesn't print any message either. This makes debugging PLL
calculation issues more difficult. Add a debug message to report the
issue, and amend the corresponding message for the OP tree to mention
"OP".

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/ccs-pll.c

index 8f9a695bd9e54241531ab7bb9f75db6749f8f31f..4eb83636e10276e18bd27b2c9e71063c716ed9f2 100644 (file)
@@ -449,6 +449,7 @@ static int ccs_pll_calculate_vt_tree(struct device *dev,
                return 0;
        }
 
+       dev_dbg(dev, "unable to compute VT pre_pll divisor\n");
        return -EINVAL;
 }
 
@@ -888,8 +889,7 @@ int ccs_pll_calculate(struct device *dev, const struct ccs_pll_limits *lim,
        }
 
        if (rval) {
-               dev_dbg(dev, "unable to compute pre_pll divisor\n");
-
+               dev_dbg(dev, "unable to compute OP pre_pll divisor\n");
                return rval;
        }