]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
net/tap: Use error_setg_file_open() for a better error message
authorMarkus Armbruster <armbru@redhat.com>
Fri, 21 Nov 2025 12:14:31 +0000 (13:14 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 7 Jan 2026 10:26:57 +0000 (11:26 +0100)
The error message changes from

    tap: open vhost char device failed

to

    Could not open '/dev/vhost-net': REASON

I think the exact file name is more useful to know than the file's
purpose.

We could put back the "tap: " prefix with error_prepend().  Not
worth the bother.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20251121121438.1249498-9-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
net/tap.c

index abe3b2d0369b4053315de85140defc3f374bf80f..bfba3fd7a705a9d73e5c4e451a787ff99ac7dcea 100644 (file)
--- a/net/tap.c
+++ b/net/tap.c
@@ -747,8 +747,7 @@ static void net_init_tap_one(const NetdevTapOptions *tap, NetClientState *peer,
         } else {
             vhostfd = open("/dev/vhost-net", O_RDWR);
             if (vhostfd < 0) {
-                error_setg_errno(errp, errno,
-                                 "tap: open vhost char device failed");
+                error_setg_file_open(errp, errno, "/dev/vhost-net");
                 goto failed;
             }
             if (!qemu_set_blocking(vhostfd, false, errp)) {