]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainGetStatsCpuProc: Remove return value
authorPeter Krempa <pkrempa@redhat.com>
Mon, 17 Feb 2025 12:51:10 +0000 (13:51 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 20 Feb 2025 14:15:40 +0000 (15:15 +0100)
The function can't fail. Remove return value and refactor callers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index 1b5e7b1d70c4716c7276a58ca94c955d6b4d3194..a93899ceb580f06c60a8aa93e30e2b8cb1ef1c0c 100644 (file)
@@ -16834,7 +16834,7 @@ qemuDomainGetStatsCpuCgroup(virDomainObj *dom,
 }
 
 
-static int
+static void
 qemuDomainGetStatsCpuProc(virDomainObj *vm,
                           virTypedParamList *params)
 {
@@ -16845,14 +16845,12 @@ qemuDomainGetStatsCpuProc(virDomainObj *vm,
     if (virProcessGetStatInfo(&cpuTime, &userTime, &sysTime,
                               NULL, NULL, vm->pid, 0) < 0) {
         /* ignore error */
-        return 0;
+        return;
     }
 
     virTypedParamListAddULLong(params, cpuTime, "cpu.time");
     virTypedParamListAddULLong(params, userTime, "cpu.user");
     virTypedParamListAddULLong(params, sysTime, "cpu.system");
-
-    return 0;
 }
 
 
@@ -16955,8 +16953,7 @@ qemuDomainGetStatsCpu(virQEMUDriver *driver,
     if (priv->cgroup) {
         qemuDomainGetStatsCpuCgroup(dom, params);
     } else {
-        if (qemuDomainGetStatsCpuProc(dom, params) < 0)
-            return -1;
+        qemuDomainGetStatsCpuProc(dom, params);
     }
 
     if (qemuDomainGetStatsCpuCache(driver, dom, params) < 0)