media: rzg2l-cru: Remove debug printouts from irq

Using dev_dbg() in irq handlers to debug per-frame events is marginally
useful and possibly not the best idea, as using printk-based helpers
introduce latencies that impact the drivers operations.

If any tracing/debugging has to be performed around frame events
in interrupt handlers, the tracing subsystem offers better alternatives.

Drop dev_dgb() calls from the CRU interrupt handlers.

Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
index fe8ab1ffea813e0083e56390a07eacd4d7371795..b6990466165e974731268746005d9681e971cf11 100644 (file)
--- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
+++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
@@ -627,9 +627,6 @@ irqreturn_t rzg2l_cru_irq(int irq, void *data)
                vb2_buffer_done(&cru->queue_buf[slot]->vb2_buf,
                                VB2_BUF_STATE_DONE);
                cru->queue_buf[slot] = NULL;
-       } else {
-               /* Scratch buffer was used, dropping frame. */
-               dev_dbg(cru->dev, "Dropping frame %u\n", cru->sequence);
        }
 
        cru->sequence++;
@@ -656,8 +653,6 @@ irqreturn_t rzg3e_cru_irq(int irq, void *data)
        slot = cru->active_slot;
        cru->active_slot = rzg2l_cru_slot_next(cru, cru->active_slot);
 
-       dev_dbg(cru->dev, "Current written slot: %d\n", slot);
-
        /* Capture frame */
        if (cru->queue_buf[slot]) {
                struct vb2_v4l2_buffer *buf = cru->queue_buf[slot];
@@ -667,9 +662,6 @@ irqreturn_t rzg3e_cru_irq(int irq, void *data)
                buf->vb2_buf.timestamp = ktime_get_ns();
                vb2_buffer_done(&buf->vb2_buf, VB2_BUF_STATE_DONE);
                cru->queue_buf[slot] = NULL;
-       } else {
-               /* Scratch buffer was used, dropping frame. */
-               dev_dbg(cru->dev, "Dropping frame %u\n", cru->sequence);
        }
 
        cru->sequence++;