ip netns: use strtol() instead of atoi()

Use strtol-based API to parse and validate integer input; atoi() does
not detect errors and may yield undefined behaviour if result can't be
represented.

v2: use get_unsigned() since network namespace is really an unsigned value.

Signed-off-by: Roman Mashak <mrv@mojatatu.com>

diff --git a/ip/ipnetns.c b/ip/ipnetns.c
index afb4978a5be7da0caa5f5993d8f8d5ff0d960208..bad7933188e6d0ba604636e0759ab7a44d41bbae 100644 (file)
--- a/ip/ipnetns.c
+++ b/ip/ipnetns.c
@@ -700,7 +700,8 @@ static int netns_set(int argc, char **argv)
 {
        char netns_path[PATH_MAX];
        const char *name;
-       int netns, nsid;
+       unsigned int nsid;
+       int netns;
 
        if (argc < 1) {
                fprintf(stderr, "No netns name specified\n");
@@ -711,7 +712,8 @@ static int netns_set(int argc, char **argv)
                return -1;
        }
        name = argv[0];
-       nsid = atoi(argv[1]);
+       if (get_unsigned(&nsid, argv[1], 0))
+               invarg("Invalid \"netnsid\" value\n", argv[1]);
 
        snprintf(netns_path, sizeof(netns_path), "%s/%s", NETNS_RUN_DIR, name);
        netns = open(netns_path, O_RDONLY | O_CLOEXEC);