]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hinic3: fix misleading error message in hinic3_open_channel()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Fri, 31 Oct 2025 11:26:44 +0000 (04:26 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 4 Nov 2025 00:38:31 +0000 (16:38 -0800)
The error message printed when hinic3_configure() fails incorrectly
reports "Failed to init txrxq irq", which does not match the actual
operation performed. The hinic3_configure() function sets up various
device resources such as MTU and RSS parameters , not IRQ initialization.

Update the log to "Failed to configure device resources" to make the
message accurate and clearer for debugging.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Fan Gong <gongfan1@huawei.com>
Link: https://patch.msgid.link/20251031112654.46187-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c

index 0fa3c790022517c14c1470409ce30f108a3c429e..bbf22811a029d74bb025843e28796745c86d8f59 100644 (file)
@@ -304,7 +304,7 @@ static int hinic3_open_channel(struct net_device *netdev)
 
        err = hinic3_configure(netdev);
        if (err) {
-               netdev_err(netdev, "Failed to init txrxq irq\n");
+               netdev_err(netdev, "Failed to configure device resources\n");
                goto err_uninit_qps_irq;
        }