media: staging: atomisp: remove redundant OOM error messages

The memory allocation functions (kvzalloc) already emit a stack dump
on failure when GFP_KERNEL is used. Printing an extra error message
is redundant and increases code size.

This resolves the checkpatch warnings:
WARNING: Possible unnecessary 'out of memory' message

Signed-off-by: Zixuan Dong <dbeidachazi@foxmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 3a4eb4f6d3be5df9be7292fd42e5c3809a1c7dac..a3cd9d3e9ce74ae6f83e0bf455376c9cb180e6a5 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -2961,11 +2961,8 @@ int atomisp_set_parameters(struct video_device *vdev,
                 * per-frame setting only works for the main output frame.
                 */
                param = kvzalloc(sizeof(*param), GFP_KERNEL);
-               if (!param) {
-                       dev_err(asd->isp->dev, "%s: failed to alloc params buffer\n",
-                               __func__);
+               if (!param)
                        return -ENOMEM;
-               }
                css_param = &param->params;
        }