]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
coverity: Check return value of setenv
authorStéphane Graber <stgraber@ubuntu.com>
Fri, 14 Feb 2014 21:06:17 +0000 (16:06 -0500)
committerStéphane Graber <stgraber@ubuntu.com>
Sat, 15 Feb 2014 00:13:47 +0000 (19:13 -0500)
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
src/lxc/attach.c

index 87826522d5ee0a27d74242a71a54560435e10683..28cf9163504667a6b06ab9ea8eb5f744e40040e9 100644 (file)
@@ -317,8 +317,10 @@ static int lxc_attach_set_environment(enum lxc_attach_env_policy_t policy, char*
                if (extra_keep_store) {
                        size_t i;
                        for (i = 0; extra_keep[i]; i++) {
-                               if (extra_keep_store[i])
-                                       setenv(extra_keep[i], extra_keep_store[i], 1);
+                               if (extra_keep_store[i]) {
+                                       if (setenv(extra_keep[i], extra_keep_store[i], 1) < 0)
+                                               SYSERROR("Unable to set environment variable");
+                               }
                                free(extra_keep_store[i]);
                        }
                        free(extra_keep_store);