]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 1419636 - Make Google Analytics use beacon/XHR instead of img tag
authorKohei Yoshino <kohei.yoshino@gmail.com>
Fri, 27 Jul 2018 14:03:40 +0000 (10:03 -0400)
committerDylan William Hardison <dylan@hardison.net>
Fri, 27 Jul 2018 14:03:40 +0000 (10:03 -0400)
Bugzilla/CGI.pm
extensions/GoogleAnalytics/web/js/analytics.js

index 03805ad1ec5e66d7c3ff448f4c9573ba23b35a9d..dbcb3ef683217afc39189244040ac8a7c254a147 100644 (file)
@@ -39,11 +39,13 @@ sub DEFAULT_CSP {
         script_src  => [ 'self', 'nonce', 'unsafe-inline', 'https://www.google-analytics.com' ],
         frame_src   => [ 'none', ],
         worker_src  => [ 'none', ],
-        img_src     => [ 'self', 'https://secure.gravatar.com', 'https://www.google-analytics.com' ],
+        img_src     => [ 'self', 'https://secure.gravatar.com' ],
         style_src   => [ 'self', 'unsafe-inline' ],
         object_src  => [ 'none' ],
         connect_src => [
             'self',
+            # This is for extensions/GoogleAnalytics using beacon or XHR
+            'https://www.google-analytics.com',
             # This is from extensions/OrangeFactor/web/js/orange_factor.js
             'https://treeherder.mozilla.org/api/failurecount/',
         ],
@@ -70,9 +72,11 @@ sub SHOW_BUG_MODAL_CSP {
     my ($bug_id) = @_;
     my %policy = (
         script_src  => ['self', 'nonce', 'unsafe-inline', 'unsafe-eval', 'https://www.google-analytics.com' ],
-        img_src     => [ 'self', 'https://secure.gravatar.com', 'https://www.google-analytics.com' ],
+        img_src     => [ 'self', 'https://secure.gravatar.com' ],
         connect_src => [
             'self',
+            # This is for extensions/GoogleAnalytics using beacon or XHR
+            'https://www.google-analytics.com',
             # This is from extensions/OrangeFactor/web/js/orange_factor.js
             'https://treeherder.mozilla.org/api/failurecount/',
         ],
index 25f7d75276b5179df3f8cd1ee459c2b4893c7522..86f1f259210793eef29b37c01fc40be1a2588a3b 100644 (file)
@@ -15,6 +15,7 @@ $(function() {
     ga('set', 'anonymizeIp', true);
     ga('set', 'location', meta.data('location'));
     ga('set', 'title', meta.data('title'));
+    ga('set', 'transport', 'beacon');
     // Track page view
     ga('send', 'pageview');
   }